search

keizerworks / invoicen

Invoicen is a simple invoice generator for freelancers and small businesses. It is a self hostable web application that can be used to generate invoices and download PDFs
MIT License
13 stars 12 forks source link

feat : landing page revamped #30

Closed amanbairagi30 closed 2 weeks ago

amanbairagi30 commented 3 weeks ago

image

amanbairagi30 commented 3 weeks ago

@aayushchugh

amanbairagi30 commented 3 weeks ago

Hi @aayushchugh , I have linted and formated the code with biome , but still there is lot of noise in the files i have used these commands

image

do you know why this happening ?

aayushchugh commented 3 weeks ago

@amanbairagi30 Thanks for the PR.

I need to discuss these design changes with my team first.

aayushchugh commented 3 weeks ago

The Layout looks great but I think we should change the colours back to black and white. @Sudarsh1010 @DMZTdhruv what do you guys think?

amanbairagi30 commented 3 weeks ago

any update on this ? @aayushchugh

Sudarsh1010 commented 3 weeks ago

@aayushchugh I think we should have at least one color. blue is looking good. what you say? I guess LGTM

Sudarsh1010 commented 3 weeks ago

Hi @aayushchugh , I have linted and formated the code with biome , but still there is lot of noise in the files i have used these commands

image

do you know why this happening ?

maybe not configured properly core team will look into it

aayushchugh commented 3 weeks ago

@Sudarsh1010 blue looks good but this rounded button doesn't look good on generate invoice page, maybe we can reduce the border radius?

Also as I can see @amanbairagi30 has changed global css which is making generate invoice page look wired.

These 3 things needs to be fixed before merging this PR @amanbairagi30

  1. Reduce button's border radius.
  2. Improve contrast of footer.
  3. Check global CSS, why it's breaking UI of invoice page.
amanbairagi30 commented 3 weeks ago

@Sudarsh1010 blue looks good but this rounded button doesn't look good on generate invoice page, maybe we can reduce the border radius?

Also as I can see @amanbairagi30 has changed global css which is making generate invoice page look wired.

These 3 things needs to be fixed before merging this PR @amanbairagi30

  1. Reduce button's border radius.
  2. Improve contrast of footer.
  3. Check global CSS, why it's breaking UI of invoice page.

Hey @aayushchugh , at generate invoice page , i can see two changes from the current version which are navbar and button . I have modified these two components which makes the difference , i can revert them if you want , but i dont think globals.css has any role in this layout shift (apart from the theme color and stuff)

amanbairagi30 commented 3 weeks ago
image image

@aayushchugh done with changes

amanbairagi30 commented 3 weeks ago

done