search

keizerworks / invoicen

Invoicen is a simple invoice generator for freelancers and small businesses. It is a self hostable web application that can be used to generate invoices and download PDFs
MIT License
13 stars 12 forks source link

Currency formatting resolved #39

Open arashveysi3 opened 2 weeks ago

arashveysi3 commented 2 weeks ago

according to #35 issue, in creating invoices page number formatting changed to currency formatting.

hope it helps :)

arashveysi3 commented 2 weeks ago

Hey @aayushchugh . thanks for reviewing my PR. so should I create a new Issue for adding a currency tab to the app or I supposed to design it within this same PR?

aayushchugh commented 2 weeks ago

@arashveysi3 You can create a new Issue and PR for the currency settings but for now, please update the code to accept dynamic currency instead of hard coding USD

arashveysi3 commented 2 weeks ago

changes made... please take a look...

arashveysi3 commented 1 week ago

roger that. sounds reasonable and good working on it...

arashveysi3 commented 1 week ago

would you please review it again!

aayushchugh commented 1 week ago

I'll review it tomorrow

arashveysi3 commented 1 week ago

Yep you are right. Please take a look again!