search

kejonaMC / CrossplatForms

Configurable Bedrock Edition forms, inventory menus, and more.
GNU General Public License v3.0
77 stars 13 forks source link

Fails to load on 1.21 #195

Open DBTDerpbox opened 3 months ago

DBTDerpbox commented 3 months ago

Describe the bug

The plugin is unable to load in 1.21 in its current state. This results in all of its functionality being unavailable.

To Reproduce

[16:34:06 INFO]: [CForms] Enabling CrossplatForms v1.5.0
[16:34:06 ERROR]: Error occurred while enabling CrossplatForms v1.5.0 (Is it up to date?)
java.lang.ExceptionInInitializerError: null
        at CrossplatForms-Spigot.jar/dev.kejona.crossplatforms.spigot.CrossplatFormsSpigot.findVersionAdapter(CrossplatFormsSpigot.java:28) ~[CrossplatForms-Spigot.jar:?]
        at CrossplatForms-Spigot.jar/dev.kejona.crossplatforms.spigot.SpigotBase.onEnable(SpigotBase.java:80) ~[CrossplatForms-Spigot.jar:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:288) ~[paper-api-1.21-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[paper-1.21.jar:1.21-119-100d75a]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-1.21.jar:1.21-119-100d75a]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-api-1.21-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:640) ~[paper-1.21.jar:1.21-119-100d75a]
        at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:589) ~[paper-1.21.jar:1.21-119-100d75a]
        at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:754) ~[paper-1.21.jar:1.21-119-100d75a]
        at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:516) ~[paper-1.21.jar:1.21-119-100d75a]
        at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:329) ~[paper-1.21.jar:1.21-119-100d75a]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1215) ~[paper-1.21.jar:1.21-119-100d75a]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:330) ~[paper-1.21.jar:1.21-119-100d75a]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 3 out of bounds for length 3
        at CrossplatForms-Spigot.jar/dev.kejona.crossplatforms.spigot.ClassNames.<clinit>(ClassNames.java:25) ~[CrossplatForms-Spigot.jar:?]
        ... 14 more
[16:34:06 INFO]: [CForms] Disabling CrossplatForms v1.5.0

Expected behaviour

The plugin would not give an error and would allow server admins and players to use its features.

Screenshots / Videos

No response

Server Version and Plugins

Paper 1.21-119-master@100d75a (2024-07-29T16:00:13Z) (Implementing API version 1.21-R0.1-SNAPSHOT)

Geyser Dump

https://dump.geysermc.org/mg8VxiD53kq8qQik350QMnfOxpYz3LP2

CrossplatForms Version

1.5.0

Additional Context

latest.log

ZherKing commented 3 months ago

I am also waiting for the fix of this issue

MiguVT commented 3 months ago

me too, there is a 1.21 branch i will try to compile to see if it fixs it

MiguVT commented 3 months ago

♥️ I will try it now, i was updating all my server plugins, lets check if it works (Remember, its a snapshot of a version that is not released, it can contain bugs but there is no updates on the version in the last month, so i think it works fine with no bugs.

Jens-Co commented 3 months ago

The compiled jar from this branch should work on 1.21 server, it's not yet in master as i did not had time to properly test it. I lack the time to properly implement the 1.21 or 1.20.6 for that matter.

If you have question feel free to ask.

MiguVT commented 3 months ago

Its working, no bugs atm, if i find some bugs i will report it here and make a PR if i can fix it

Jens-Co commented 3 months ago

Great thanks, the main issue lies in the nms, we should be looking for a way to remove nms completely in the future.

DBTDerpbox commented 3 months ago

I'm not sure why I didn't bother checking to see if there was an updated branch, thank you

MiguVT commented 3 months ago

lack the time to properly implement the 1.21 or

I was using it a month and everything is working without bugs or errors (purpur 1.21) ♥️

Konicai commented 2 months ago

If you have a fix for anything you can create a PR, which will provide downloads. Please do NOT link external jar downloads of any type here.

MiguVT commented 2 months ago

If you have a fix for anything you can create a PR, which will provide downloads. Please do NOT link external jar downloads of any type here.

Oh ok, sorry, i dont fixed anything, i just compiled it, can you upload or run an action for get the 1.21 CrossplatForms download?? tysm, too much servers use it and i know how to compile but too many people dont know.

Jens-Co commented 2 months ago

You can find a compiled 1.21 dev build on our discord channel.

Konicai commented 2 months ago

Use the builds available on https://ci.kejonamc.dev/job/CrossplatForms/job/dev/ please

DBTDerpbox commented 1 week ago

Coming back to this, you're probably aware but the latest development build (using https://ci.kejonamc.dev/job/CrossplatForms/job/dev/) is incompatible with 1.21.3, not sure if this should of been a new issue or not, so I'm sorry if it should of been

Log: latest.log

MiguVT commented 1 week ago

Rn we don't need to request an update, it should be an issue when stable 1.21.3 paper released