search

kek / sublime-expand-selection-to-quotes

Sublime Text plugin to expand selection to surrounding quotes
107 stars 13 forks source link

Change default shortcut #10

Open kdemidov opened 8 years ago

kdemidov commented 8 years ago

I think to be more consistent with some other "Expand selection to ..." commands, it makes sense to change the default shortcut from Ctrl+' to Super+Shift+'. What do you think?

heaversm commented 7 years ago

You can change this yourself by going (in ST3) to - preferences > key bindings. This should open two files - the default mac file, and a user file (.sublime-keymap - user). In that file, add an entry:

{ "keys": ["command+'"], "command": "expand_selection_to_quotes"}
kdemidov commented 7 years ago

Thanks, I already use that shortcut. I just wanted to suggest you to change a default shortcut if you think it makes sense.

kek commented 3 years ago

It does sound like a reasonable suggestion if it would be more in line with other "expand selection to" commands. The plugin did originally have a similar shortcut (Super-Shift-Q etc) but changed it in https://github.com/kek/sublime-expand-selection-to-quotes/commit/7ee05288f0c631ebfb20f8f6fd99e8cafb1dd538 for a reason I can't remember.

kek commented 3 years ago

Opening again as it is a valid suggestion. My worry is to change the shortcut that some people might have gotten are used to, since it seems that the plugin actually does have a few users. Perhaps to keep Ctrl+' and add Super+Shift+'? And put the new shortcut last in the list as it seems that is what will be shown in the menu. After a while perhaps remove the old shortcut. I'm not sure if it's possible to pop up a message to users when a Sublime plugin is updated informing of a removed or deprecated shortcut.