keke101 / pe

0 stars 0 forks source link

Divider Parameter Accepts Erroneous Parameters #3

Open keke101 opened 3 years ago

keke101 commented 3 years ago

Parameters that are not purely integer are accepted as valid input.

E.g.: divider a1a, divider askdmaslk2

image.png

nus-pe-bot commented 3 years ago

Team's Response

Issue rejected as it is by design that the app accepts excessively typed commands, .

The reason for this is to prevent frustration when the fast typists makes typos in the commands. For instance, if the user types divider -1 or divider awe1 instead of divider 1, it is still intuitive to guess that the user wanted to change the divider to option 1 so it is logical to make the change despite the typo. It is clear user had the intent of changing the divider when they already keyed in the word divider correctly (unlikely to randomly keysmash the word divider). So it makes more sense to accept the command based on that intent as long as the apropriate digit eg digit 1 is in the command instead of forcing the user to retype it in again.

Moreover, the user is able to perform the command as intended in the UG regardless.

In retrospect, this could have been better communicated to the user in the UG, but that is a seperate UG issue.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree this might be a UG bug. Nevertheless, it should not be rejected.


:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]