search

kekeh / angular-mydatepicker

Angular datepicker and date range picker :date:
https://kekeh.github.io/angular-mydatepicker/
MIT License
1 stars 11 forks source link

On keyup event doesn't emit event from reactive forms valueChanges.subscribe #27

Closed mchcjcols closed 4 years ago

mchcjcols commented 4 years ago

Regards reactive forms and subscribing to the valueChanges event.

The ngx-datepicker announced a valueChanges event when the user typed a date in the input text field (ie onkeyup event). The angular-mydatepicker only announces valueChanges event on the onBlur event.

kekeh commented 4 years ago

Hello @mchcjcols

True but if you implement this https://github.com/kekeh/angular-mydatepicker#inputfieldchanged-callback callback you know when the value of input field changes.

Example: https://github.com/kekeh/angular-mydatepicker/wiki/inputFieldChanged-callback

Is this enough?

kekeh commented 4 years ago

I fixed this issue. Now in every keyup of input box the dirty and the touched values are set to true.

Install the latest version 0.4.0 from npm.

mchcjcols commented 4 years ago

The 0.4.0 seems to work and passes my unit tests. Thank you.

From: Keke notifications@github.com Reply-To: kekeh/angular-mydatepicker reply@reply.github.com Date: Tuesday, February 11, 2020 at 4:01 AM To: kekeh/angular-mydatepicker angular-mydatepicker@noreply.github.com Cc: Matthew Charles Hewlett matthew.hewlett@ChurchofJesusChrist.org, Mention mention@noreply.github.com Subject: Re: [kekeh/angular-mydatepicker] On keyup event doesn't emit event from reactive forms valueChanges.subscribe (#27)

I fixed this issue. Now in every keyup of input box the dirty and the touched values are set to true.

Install the latest version 0.4.0 from npm.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkekeh%2Fangular-mydatepicker%2Fissues%2F27%3Femail_source%3Dnotifications%26email_token%3DAOP4DF4QCY3VNCTQ4BGEX6DRCKAPDA5CNFSM4KSXRAXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELMAA4Y%23issuecomment-584581235&data=02%7C01%7Cmatthew.hewlett%40churchofjesuschrist.org%7C9586516450564954534408d7aee1b177%7C61e6eeb35fd74aaaae3c61e8deb09b79%7C0%7C0%7C637170156688235283&sdata=NJ4xdtIi8zyXJExv%2FHIufnK8xztCvaI7dm3ucCMyEfE%3D&reserved=0, or unsubscribehttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOP4DF6ICF4S7C3PGPU5AGDRCKAPDANCNFSM4KSXRAXA&data=02%7C01%7Cmatthew.hewlett%40churchofjesuschrist.org%7C9586516450564954534408d7aee1b177%7C61e6eeb35fd74aaaae3c61e8deb09b79%7C0%7C0%7C637170156688235283&sdata=OPqwBFGKP9JgrB%2FEk5Bv1v0csaS%2BD8hpOFRWxuCOjkk%3D&reserved=0.

kekeh commented 4 years ago

It is my pleasure :-)