search

kekekeks / XamlX

General purpose pluggable XAML compiler with no runtime dependencies.
MIT License
319 stars 55 forks source link

Fixed Transform method of ResolveContentPropertyTransformer #110

Closed ds1709 closed 6 months ago

ds1709 commented 7 months ago
ds1709 commented 7 months ago

I ran tests localy and it complete successfuly, so I don't understand why Run tests task fails in pipeline.

MrJul commented 7 months ago

I ran tests localy and it complete successfuly, so I don't understand why Run tests task fails in pipeline.

You're using C# 12 collection expressions, but XamlX hasn't been updated to .NET 8 SDK yet.

Also, please add your tests to the existing XamlParserTests project instead of creating a new project - the files there are shared between several test projects, to allow the tests to run for both SRE (System.Reflection.Emit) and Cecil in several projects.

ds1709 commented 7 months ago

I moved my tests in XamlParserTests project, and now I have problems with PublikKeys. Should I specify PublikKey in InternalsVisibleTo items or not? Also, error CS0103: The name 'offender' does not exist in the current context still persists (it's not my code).

ds1709 commented 7 months ago

Well, seems like it's all OK now.

ds1709 commented 6 months ago

Found critical error.