search

kekland / croppy

A fully customizable image cropper for Flutter, in Flutter
MIT License
105 stars 30 forks source link

Add Arabic localizations #9

Closed Milad-Akarie closed 1 year ago

kekland commented 1 year ago

Hi! @Milad-Akarie, thanks for your contribution! This will be released as a minor update in the next day.

Just to confirm - does the RTL layout look good on the built-in Material and Cupertino croppers? I'm not too familiar with RTL layouts to spot if anything looks odd

kekland commented 1 year ago

I'll merge this, assuming that everything looks good :P

Let me know here if anything needs to be tweaked or changed in terms of the layout.

kekland commented 1 year ago

Deployed in version 1.1.1

Milad-Akarie commented 1 year ago

Hey @kekland sorry for the late response, I'm swamped, Yes, RTL layout looks fine. Thanks for this great package btw.

I have a little suggestion regarding the fact that the locale must be supported for the package to work, I'm working on an App that only supports AR locale and the plugin would just throw an error, I was in a stage when I wanted to test the plugin before I invest time in creating a PR that adds my locale, so I'd suggest that the plugin use a default locale, "EN" for example when the requested locale is not supported.

Also I think this part needs to be changed in the docs CroppyLocalizationDelegate() => CroppyLocalizations.delegate

kekland commented 1 year ago

Good catch, I didn't think that would throw. First time trying to add localization to a package :P

Will fix this tomorrow