search

kekscom / osmbuildings

OSM Buildings Classic 2.5D
http://osmbuildings.org
BSD 2-Clause "Simplified" License
505 stars 140 forks source link

OpenLayers 5 Support #115

Closed jmclayt closed 5 years ago

jmclayt commented 5 years ago

…which works with OpenLayers 5

kekscom commented 5 years ago

Hi, Thank you very much for contributing! What would be a setup to test this?

I'd not do this change on dist files as they have tendency to be overwritten on build. I'm fine to put this in the right place later on.

jmclayt commented 5 years ago

@kekscom I've added an example under test and removed OSMBuildings-OL5.debug.js under dist. The example I added has a package.json and uses parcel. I have a README.md that explains the process. If you ever decide to convert your functions to classes supported by es6, this might serve as a good place to start and save you some time. Thanks.

kekscom commented 5 years ago

Apologies for the delay. This looks really good and the additions making it very usable. Thanks!

jmclayt commented 5 years ago

Awesome, again, thanks for continuing to maintain OSMBuildings.