Questions about min_height and colors

[butscharoni]

Hi,

I just can't get min_height to work. It seems to work fine in the examples you provide, however, with my own data, all polygons always start at ground level. What could be the issue here?

Also, when I use low building height, the buildings soon get simplified, sometimes even on the highest zoom level. When this happens, they also loose their coloring. Can U somehow prevent this? In the best case, I don't want the simplifying at all, but just keeping the coloring would also be helpful.

Also, really great library! The buildings look really cool! Thanks for your work!

best,

bastian

[kekscom]

Hi Bastian, I need a bit more detail about how you are using min_height: is it GeoJSON or from a database? You are right about simplification. It occurs quite early and removes a lot of information. At the moment, flat buildings are just roof in default color. I'm fine to make this configurabe by very next version.

[kekscom]

TICKET: make flat buildings simplification configurable, probably always allow colors.

[butscharoni]

Hi Jan,

I'm using GeoJSON, here is an excerpt:

{"type": "Feature",
                            "properties": {
                                "wallColor": "rgb(255,0,0)",
                                "roofColor": "rgb(255,0,0)",
                                "height": 130,
                                "min_height": 50
                            },
                            "geometry": {"type": "Polygon", "coordinates": [[[8.572966877368316, 50.14990881440253], [8.572933224309073, 50.14989418151951], [8.572972886843182, 50.14985593062868], [8.573007341165738, 50.14987005008859], [8.572966877368316, 50.14990881440253]]]}},

[kekscom]

Ah ok. It was not enabled for GeoJSON. I made a change for that in: https://github.com/kekscom/osmbuildings/commit/07991d3f253c3ec7fe818e31920caffafbb9a8e8 Please try again with property minHeight

[butscharoni]

Thanks, that did it. Much appreciated!

best,

bastian

[kekscom]

You're welcome! I'd like to keep the issue open for the flat buildings optimization issue.

[bennlich]

Yes--it seems weird to specify minimum height on a building by building basis. In my tests, I've just been setting FlatBuildings.maxHeight to 0 in FlatBuildings.js.

[kekscom]

@bennlich Not exactly, min_height has a different purpose. See http://wiki.openstreetmap.org/wiki/Key:min_height :-)

Setting FlatBuildings.maxHeight is a fair solution to turn off the optimization entirely. I'd like to offer that as public setting. But also visually improve optimized renderer a bit to encourage its usage.

[bennlich]

Oh, I see. So min_height is the depth below ground? Does osmbuildings draw that? Or just subtract it from the total height?

On Mon, Apr 22, 2013 at 11:23 PM, Jan Marsch notifications@github.comwrote:

@bennlich https://github.com/bennlich Not exactly, min_height has a different purpose. See http://wiki.openstreetmap.org/wiki/Key:min_height :-)

Setting FlatBuildings.maxHeight is a fair solution to turn off the optimization entirely. I'd like to offer that as public setting. But also visually improve optimized renderer a bit to encourage its usage.

— Reply to this email directly or view it on GitHubhttps://github.com/kekscom/osmbuildings/issues/32#issuecomment-16841446 .

[kekscom]

It draws it :-) See http://osmbuildings.org/sketch/?lat=52.52077&lon=13.40858&z=17

[bennlich]

Hmm. I don't think I'm seeing it. Are some of those buildings underground?

On Tue, Apr 23, 2013 at 12:01 AM, Jan Marsch notifications@github.comwrote:

It draws it :-) See http://osmbuildings.org/sketch/?lat=52.52077&lon=13.40858&z=17

— Reply to this email directly or view it on GitHubhttps://github.com/kekscom/osmbuildings/issues/32#issuecomment-16842517 .

[bennlich]

Oh, I get it! It's the distance from the ground to the base of the ring structure?

On Tue, Apr 23, 2013 at 12:03 AM, Benny Lichtner kak0iy0kunai@gmail.comwrote:

Hmm. I don't think I'm seeing it. Are some of those buildings underground?

On Tue, Apr 23, 2013 at 12:01 AM, Jan Marsch notifications@github.comwrote:

It draws it :-) See http://osmbuildings.org/sketch/?lat=52.52077&lon=13.40858&z=17

— Reply to this email directly or view it on GitHubhttps://github.com/kekscom/osmbuildings/issues/32#issuecomment-16842517 .

[kekscom]

Yes, exactly.

[kekscom]

I'm about to improve the behavior for flat buildings in general.