search

kekscom / osmbuildings

OSM Buildings Classic 2.5D
http://osmbuildings.org
BSD 2-Clause "Simplified" License
505 stars 141 forks source link

detach drawing functions from leaflet integration #8

Closed ramunasd closed 12 years ago

ramunasd commented 12 years ago

Would be nice to have buildings layer based on OpenLayers.

kekscom commented 12 years ago

Agreed. I'll need to check their code.

Am 19.07.2012 um 15:20 schrieb Ramūnas reply@reply.github.com:

Would be nice to have buildings layer based on OpenLayers.

Reply to this email directly or view it on GitHub: https://github.com/kekscom/osmbuildings/issues/8

kekscom commented 12 years ago

Two sided: detaching is preferred while there are lots of engine specific codes which make it more performant. Try to think mobile first, where it is extremely fragile regarding performance. But yes, I'll try to set up a build process to handle this.

Am 19.07.2012 um 15:20 schrieb Ramūnas reply@reply.github.com:

Would be nice to have buildings layer based on OpenLayers.

Reply to this email directly or view it on GitHub: https://github.com/kekscom/osmbuildings/issues/8

ramunasd commented 12 years ago

There is function addTo(), we could write another one for openlayers and reuse same event handlers

kekscom commented 12 years ago

That's one thing the code changes this night have been about ;-)

Am 25.07.2012 um 08:42 schrieb Ramūnas reply@reply.github.com:

There is function addTo(), we could write another one for openlayers and reuse same event handlers

Reply to this email directly or view it on GitHub: https://github.com/kekscom/osmbuildings/issues/8#issuecomment-7241866

kekscom commented 12 years ago

Done with v0.1.7a