search

kekshd / keks

an elearning system with basic answer types yes/no/matrix
http://keks.uni-hd.de
ISC License
10 stars 4 forks source link

Video link bug and bug #109 #117

Closed ajayme closed 7 years ago

fosterfarrell9 commented 7 years ago

Awesome! It seems to work nicely. Could you please still do two things:

  1. Display the video links in a way that they open in an external tab when being clicked upon (e.g. with target="_blank")
  2. Please make the pull request for the "dev"-branch instead of "master". As "master" is more or less directly connected to the actual keks site, we should first merge to "dev".
oqpvc commented 7 years ago

Cool!

I merged it into dev.

ajayme commented 7 years ago

Hello,

Is there something else you want me to do?

On 26. Jun 2017, at 08:45, fosterfarrell9 notifications@github.com wrote:

Awesome! It seems to work nicely. Could you please still do two things:

Display the video links in a way that they open in an external tab when being clicked upon (e.g. with target="_blank") Please make the pull request for the "dev"-branch instead of "master". As "master" is more or less directly connected to the actual keks site, we should first merge to "dev". — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

fosterfarrell9 commented 7 years ago

Issue #119 should be the next priority, then #113. If there is a way to implement #115, then this would be great, too. And after that, it is maybe a good idea to start the work on #106.