search

kekshd / keks

an elearning system with basic answer types yes/no/matrix
http://keks.uni-hd.de
ISC License
10 stars 4 forks source link

shuffle questions more #30

Closed beccy closed 11 years ago

beccy commented 11 years ago

This is what we experienced:

we created a new account and started a session with 5 questions then we said give me 5 more.

the next two sessions consisted of almost the same question - even though they were answered correctly in the first session. The first one was exactly the same in all three sessions.

breunigs commented 11 years ago

How many questions were there? From the top of my head I can't think of the method not being shuffling enough.

beccy commented 11 years ago

we have a pool of 30+ questions. We did three sessions of 5 questions each.

breunigs commented 11 years ago

I can have a look at this sometime although I attribute this to you small test base for now. These 30 questions were all on the same level or does that include sub questions?

breunigs commented 11 years ago

as far as I understand the documentation this shouldn’t be necessary. It’s not really clear to me:

The elements are chosen by using random and unique indices into the array in order to
ensure that an element doesn’t repeat itself unless the array already contained duplicate
elements.

It mentions the elements are chosen in order, but I can observe they are shuffled when I try it locally, even without the patch.

breunigs commented 11 years ago 
2013-04-29 19:37:52. [dbg] RANDOM DEBUG: cnt=5 samp=36  20  21  72  29 quests=9  10  11  12  13  14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  43  44  45  46  47  48  49  51  53  55  56  59  61  62  63  64  65  72  73  74  75  76  77 (pid:19593)

2013-04-29 19:38:03. [dbg] RANDOM DEBUG: cnt=5 samp=47  46  73  32  40 quests=9  10  11  12  13  14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  43  44  45  46  47  48  49  51  53  55  56  59  61  62  63  64  65  72  73  74  75  76  77 (pid:19593)
2013-04-29 19:38:16. [dbg] RANDOM DEBUG: cnt=5 samp=55  46  17  74  34 quests=9  10  11  12  13  14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  43  44  45  46  47  48  49  51  53  55  56  59  61  62  63  64  65  72  73  74  75  76  77 (pid:19593)
2013-04-29 19:38:23. [dbg] RANDOM DEBUG: cnt=5 samp=23  39  14  31  77 quests=9  10  11  12  13  14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  43  44  45  46  47  48  49  51  53  55  56  59  61  62  63  64  65  72  73  74  75  76  77 (pid:19593)
2013-04-29 19:38:24. [dbg] RANDOM DEBUG: cnt=5 samp=22  45  17  10  25 quests=9  10  11  12  13  14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  43  44  45  46  47  48  49  51  53  55  56  59  61  62  63  64  65  72  73  74  75  76  77 (pid:19593)
2013-04-29 19:38:26. [dbg] RANDOM DEBUG: cnt=5 samp=33  28  65  13  37 quests=9  10  11  12  13  14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  43  44  45  46  47  48  49  51  53  55  56  59  61  62  63  64  65  72  73  74  75  76  77 (pid:19593)
2013-04-29 19:38:59. [dbg] RANDOM DEBUG: cnt=5 samp=32  26  24  43  55 quests=9  10  11  12  13  14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  43  44  45  46  47  48  49  51  53  55  56  59  61  62  63  64  65  72  73  74  75  76  77 (pid:19593)
2013-04-29 19:39:01. [dbg] RANDOM DEBUG: cnt=5 samp=64  32  22  44  23 quests=9  10  11  12  13  14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  43  44  45  46  47  48  49  51  53  55  56  59  61  62  63  64  65  72  73  74  75  76  77 (pid:19593)
2013-04-29 19:39:02. [dbg] RANDOM DEBUG: cnt=5 samp=61  22  73  59  16 quests=9  10  11  12  13  14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  43  44  45  46  47  48  49  51  53  55  56  59  61  62  63  64  65  72  73  74  75  76  77 (pid:19593)

I added some debug logging locally. This is the data it spits out for non-registered users. cnt is how many questions to obtain, the list after samp is which questions were chosen and quests were the questions it was able to choose from.

It looks random enough, though I didn’t throw proper statistics at it.

breunigs commented 11 years ago 
2013-04-29 19:45:29. [dbg] RANDOM DEBUG: cnt=5 samp=9  10  11  12  13 quests=14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  43  44  45  46  47  48  49  51  53  55  56  59  61  62  63  64  65  72  73  74  75  76  77  signed_in=true (pid:19593)
2013-04-29 19:45:34. [dbg] RANDOM DEBUG: cnt=5 samp=9  10  11  12  13 quests=14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  43  44  45  46  47  48  49  51  53  55  56  59  61  62  63  64  65  72  73  74  75  76  77  signed_in=true (pid:19593)
2013-04-29 19:45:41. [dbg] RANDOM DEBUG: cnt=5 samp=9  10  11  12  13 quests=14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  43  44  45  46  47  48  49  51  53  55  56  59  61  62  63  64  65  72  73  74  75  76  77  signed_in=true (pid:19593)
2013-04-29 19:45:46. [dbg] RANDOM DEBUG: cnt=5 samp=9  10  11  12  13 quests=14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  43  44  45  46  47  48  49  51  53  55  56  59  61  62  63  64  65  72  73  74  75  76  77  signed_in=true (pid:19593)
2013-04-29 19:45:50. [dbg] RANDOM DEBUG: cnt=5 samp=9  10  11  12  13 quests=14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  43  44  45  46  47  48  49  51  53  55  56  59  61  62  63  64  65  72  73  74  75  76  77  signed_in=true (pid:19593)
2013-04-29 19:45:55. [dbg] RANDOM DEBUG: cnt=5 samp=9  10  11  12  13 quests=14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  43  44  45  46  47  48  49  51  53  55  56  59  61  62  63  64  65  72  73  74  75  76  77  signed_in=true (pid:19593)

okay it appears roulette selection is broken

breunigs commented 11 years ago

The change is pushed live. Please reopen this ticket if the issue persists.