search

kel-z / HSR-Scanner

Scanner for exporting light cone, relic, and character data from Honkai: Star Rail to JSON format.
GNU General Public License v3.0
178 stars 13 forks source link

Bug: HSR Scan fails if switch app on OCR stage #19

Closed supernova-ws closed 1 year ago

supernova-ws commented 1 year ago

If after scan phase when HSR Scanner OCRs screenshot I switch to other app - not HSR itself or HSR Scanner - sometime later will abort OCR and fail whole scan process. Especially it's annoying when scan fails after scanning 800+ relics. For now I can't find exact sequence how to reproduce this behavior. I will monitor HSR Scanner behavior.

v.0.2.3 beta

kel-z commented 1 year ago

I think I know what you're talking about. The "press enter to cancel" still applies even after all the screenshotting is done, which I don't want.

I'll change this so it doesn't remain in effect when the screenshotting process is done, since I've also had times when I would switch to Discord after scanning, only the find out that I cancelled the OCR because I pressed enter to send a message.

Thanks!

supernova-ws commented 1 year ago

Yes! That's looks like it. Now I recall that I may press "Enter" in cases when it's stopped OCRing. Unlocking "Enter" on OCR phase surely would be very cool!

kel-z commented 1 year ago

21 Implemented.