kel85uk / ewoms

The eWoms Porous Media Simulation Framework
Other
1 stars 0 forks source link

Task#1: Add salt precipitation model in Ewoms #1

Open kel85uk opened 7 years ago

kel85uk commented 7 years ago

Task to add the salt model of Dumux into ewoms. Completed benchmark 1, 2, and 3a. This task focuses on benchmark 3b.

Definitions:

Benchmark 1 = Evaporation without salt Benchmark 2 = Evaporation with salt but no saturated salt concentration Benchmark 3a = Evaporation with salt and with saturated salt concentration (no tracking) Benchmark 3b = Benchmark 3a + tracking of salt lost in water phase

kel85uk commented 7 years ago

Salt storage looks funny.

kel85uk commented 7 years ago

Hint to solve the problem is to have a boolean vector for each grid points to determine if maximum salt saturation has occured. If so, then, use a proportional controller source term to track max salt saturation.

kel85uk commented 7 years ago

Potentially, we could use the saturation(phaseIdx).isActive flag to only remove when it is a liquid. This is maybe where the error comes in when saturation of liquid = 0!

kel85uk commented 7 years ago

Salt fugacity: There is difference between Dumux and OPM. The implementation in Dumux matches really well with Tough-2, and this is due to the example case within dumux for salt.