search

keldaanCommunity / pokemonAutoChess

Pokemon Auto Chess Game. Made by fans for fans. Open source, non profit. All rights to the Pokemon Company.
https://pokemon-auto-chess.com/
GNU General Public License v3.0
1.15k stars 359 forks source link

Fixed quadratically scaling crit chance on some abilities. #2440

Closed Exeatop closed 2 days ago

Exeatop commented 3 days ago

Sky Attack Shadow and Night Slash can crit by default. Their crit calculation is applied twice by including crit || which gives a crit probability scaling quadratically with crit chance if the user is holding Reaper Cloth. Removing crit || fixes the issue.

sylvainpolletvillard commented 3 days ago

Intended, it only buffs crit chance when reaper cloth is equipped, and give a good reason to equip reaper cloth on these units

Exeatop commented 3 days ago

Intended, it only buffs crit chance when reaper cloth is equipped, and give a good reason to equip reaper cloth on these units

Oh is this intended? If that's the case then the other abilities that crit by default should have it added since they're currently missing the reaper cloth crit chance.