kelektiv / node-cron

Cron for NodeJS.
MIT License
8.31k stars 617 forks source link

fix: revert runOnce breaking changes #760

Closed sheerlox closed 8 months ago

sheerlox commented 8 months ago

Description, Motivation & Context

This PR restores the original runOnce property, which was changed in #740 without considering it a breaking change since it was an undocumented internal property. That was a mistake because consumers relied on it. The property was added back as a read-only getter in #751, which was another naive decision from me, because not only did consumers rely on reading it, but it seems (based on the Renovate passing tests percentage below) that they actually also mutate the property to change their jobs' behavior.

image

Related Issues

How Has This Been Tested?

Test case already present from #740.

Types of changes

Checklist:

ncb000gt commented 8 months ago

:tada: This PR is included in version 3.1.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: