kelektiv / node.bcrypt.js

bcrypt for NodeJs
MIT License
7.51k stars 518 forks source link

Critical dependency: the request of a dependency is an expression #835

Closed SSmale closed 4 years ago

SSmale commented 4 years ago

WARNING in ./node_modules/bcrypt/bcrypt.js 6:15-36 Critical dependency: the request of a dependency is an expression

SSmale commented 4 years ago

rm -rfing the node_modules folder and rebuilding seemed to fix this issue.

recrsn commented 4 years ago

This is weird. Please feel free to re-open if it happens again.

soscler commented 4 years ago

Hi @agathver I got the same error on Nativescript 6 (with Angular 8) and node 12 rm -rf didn't work. Is bcrypt supported on client side frameworks ?

Below is a part of the logs

WARNING in ../node_modules/bcrypt/bcrypt.js 6:15-36
Critical dependency: the request of a dependency is an expression
 @ ./app/signup/signup.component.ts
 @ ./app/signup/signup.module.ts
 @ ./app/app-routing.module.ts
 @ ./app/app.module.ts
 @ ./main.ts

WARNING in ../node_modules/node-pre-gyp/lib/pre-binding.js 20:22-48
Critical dependency: the request of a dependency is an expression
 @ ../node_modules/node-pre-gyp/lib/node-pre-gyp.js
 @ ../node_modules/bcrypt/bcrypt.js
 @ ./app/signup/signup.component.ts
 @ ./app/signup/signup.module.ts
 @ ./app/app-routing.module.ts
 @ ./app/app.module.ts
 @ ./main.ts

WARNING in ../node_modules/node-pre-gyp/lib/util/versioning.js 17:20-67
Critical dependency: the request of a dependency is an expression
 @ ../node_modules/node-pre-gyp/lib sync ^\.\/.*$
 @ ../node_modules/node-pre-gyp/lib/node-pre-gyp.js
 @ ../node_modules/bcrypt/bcrypt.js
 @ ./app/signup/signup.component.ts
 @ ./app/signup/signup.module.ts
 @ ./app/app-routing.module.ts
 @ ./app/app.module.ts
 @ ./main.ts

WARNING in ../node_modules/node-pre-gyp/lib/util/compile.js
Module not found: Error: Can't resolve 'npm' in 'C:\Users\soscler\Desktop\projects\touche-consulting\payme\node_modules\node-pre-gyp\lib\util'
 @ ../node_modules/node-pre-gyp/lib/util/compile.js
 @ ../node_modules/node-pre-gyp/lib sync ^\.\/.*$
 @ ../node_modules/node-pre-gyp/lib/node-pre-gyp.js
 @ ../node_modules/bcrypt/bcrypt.js
 @ ./app/signup/signup.component.ts
 @ ./app/signup/signup.module.ts
 @ ./app/app-routing.module.ts
 @ ./app/app.module.ts
 @ ./main.ts

WARNING in ../node_modules/node-gyp/lib/Find-VS2017.cs 7:6
Module parse failed: Unexpected token (7:6)
You may need an appropriate loader to handle this file type.
| // Usage:
| // powershell -ExecutionPolicy Unrestricted -Version "2.0" -Command "&{Add-Type -Path Find-VS2017.cs; [VisualStudioConfiguration.Main]::Query()}"
> using System;
| using System.Text;
| using System.Runtime.InteropServices;
 @ ../node_modules/node-gyp/lib sync ^\.\/.*$ ./Find-VS2017.cs
 @ ../node_modules/node-gyp/lib/node-gyp.js
 @ ../node_modules/node-pre-gyp/lib/util/compile.js
 @ ../node_modules/node-pre-gyp/lib sync ^\.\/.*$
 @ ../node_modules/node-pre-gyp/lib/node-pre-gyp.js
 @ ../node_modules/bcrypt/bcrypt.js
 @ ./app/signup/signup.component.ts
 @ ./app/signup/signup.module.ts
 @ ./app/app-routing.module.ts
 @ ./app/app.module.ts
 @ ./main.ts
recrsn commented 4 years ago

@soscler It isn't. If you need hashing in client-side, please use https://www.npmjs.com/package/bcryptjs

soscler commented 4 years ago

Ok thanks.