kelektiv / node.bcrypt.js

bcrypt for NodeJs
MIT License
7.43k stars 510 forks source link

v5.0.1 release doesn't include build for all the architectures as 5.0.0 does #910

Closed ktrz closed 2 years ago

ktrz commented 2 years ago

release v5.0.1 doesn't include eg. ARM architecture builds which causes errors when trying to install on M1 Macs

#20 14.38 npm ERR! node-pre-gyp info check checked for "/backend/node_modules/bcrypt/lib/binding/napi-v3/bcrypt_lib.node" (not found)
#20 14.38 npm ERR! node-pre-gyp http GET https://github.com/kelektiv/node.bcrypt.js/releases/download/v5.0.1/bcrypt_lib-v5.0.1-napi-v3-linux-arm64-musl.tar.gz
#20 14.38 npm ERR! node-pre-gyp ERR! install response status 404 Not Found on https://github.com/kelektiv/node.bcrypt.js/releases/download/v5.0.1/bcrypt_lib-v5.0.1-napi-v3-linux-arm64-musl.tar.gz 
#20 14.38 npm ERR! node-pre-gyp WARN Pre-built binaries not installable for bcrypt@5.0.1 and node@16.13.1 (node-v93 ABI, musl) (falling back to source compile with node-gyp) 
#20 14.38 npm ERR! node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/kelektiv/node.bcrypt.js/releases/download/v5.0.1/bcrypt_lib-v5.0.1-napi-v3-linux-arm64-musl.tar.gz 

It works on version 5.0.0

Probably this is what's causing Issue #901

ktrz commented 2 years ago

I misunderstood the error