search

kelemen / netbeans-gradle-project

This project is a NetBeans plugin able to open Gradle based Java projects. The implementation is based on Geertjan Wielenga's plugin.
173 stars 57 forks source link

Changed source file resolution to accommodate javafx 11 libraries. #400

Closed DeanWookey closed 5 years ago

DeanWookey commented 5 years ago

The sources associated with openjfx (https://openjfx.io/openjfx-docs/#gradle) libraries aren't linked properly because there are multiple binaries associated with a single set of source files as seen here: http://central.maven.org/maven2/org/openjfx/javafx-controls/11/

I have made some changes. If they are not appropriate, I'll be happy to make any changes you require.

kelemen commented 5 years ago

Thanks for the PR. I would need some adjustments because this breaks the javadoc lookup. GradleCacheByBinaryLookup is also used to search for javadoc artifacts not just sources. So the file name conversion must rely on binaryToSearchedEntry (though it can be refactored to take more arguments, say the parent directory name you are using) in all cases.

DeanWookey commented 5 years ago

Thanks for the feedback. I moved some of the logic into the GradleFileUtils. I wasn't sure exactly what you meant with the refactor, but I can take that approach if you want. If there's anything else you need, I'm still happy to do it.

kelemen commented 5 years ago

Thanks, I have merged the changes into master.