search

kelemen / netbeans-gradle-project

This project is a NetBeans plugin able to open Gradle based Java projects. The implementation is based on Geertjan Wielenga's plugin.
173 stars 57 forks source link

Added source support for custom local maven repos #413

Closed DeanWookey closed 5 years ago

DeanWookey commented 5 years ago

As mentioned in https://github.com/kelemen/netbeans-gradle-project/pull/412, this adds support for source and javadoc file resolution in a custom local maven repository. It achieves this by checking if the source/javadoc files associated with the given binary file exist in the place we expect it to be. If not, it returns a null result so that another query can handle the resolution.

I'm not sure if there is a way to access the list of loaded repositories gradle has, but if this approach proves problematic, I can look into it.

kelemen commented 5 years ago

I will review your PR on the weekend, and see if I have any concern.

kelemen commented 5 years ago

It seems mostly fine but can you remove the position attribute from your annotation to ensure that your queries will be amongst the last resort checks?

Also, please remove unused imports from files.

DeanWookey commented 5 years ago

Pushed the changes you mentioned. If there's anything else, let me know.

kelemen commented 5 years ago

Thank you, I have merged your changes.