search

kelemen / netbeans-gradle-project

This project is a NetBeans plugin able to open Gradle based Java projects. The implementation is based on Geertjan Wielenga's plugin.
170 stars 57 forks source link

Create dialog for finding and inserting dependencies #58

Open KhArtNJava opened 11 years ago

KhArtNJava commented 11 years ago

Hello. Please, make window, in which user will add dependencies, like as in Maven project, with search in Global maven repo and in local Maven repo. Sorry my bad English. Best regards, Arthur Khusnutdinov.

kelemen commented 11 years ago

This is very unlikely to be fixed. See #56. An "insert artifact notation here" plugin would be a more feasible option. I won't forget about this issue but chances of me implementing it is very low. Sorry.

kelemen commented 11 years ago

I have closed the issue because I believe that it won't be fixed.

The window you are talking about is part of the Maven plugin, I can't just "use" it. Anyway, although creating such dialog takes considerable time as well (for example, because I have to find and learn new API) but the real reason why I don't think this issue will be fixed is due to the need of being able to parse and analyze the build script. After that, I still have to adjust the code, so that it still works properly. That is, it needs way too much time for just a simple feature. You see, I code this plugin entirely in my free time and don't want to spend that much time on a feature which I consider a mild advantage (I assume, many wouldn't bother using it, I didn't use it in Maven as well).

What I consider more sensible is to allow the user press "alt + insert" in the build script and choose to insert a dependency in a similar dialog. However, I'm not currently planning to add this as well. I gladly accept pull requests though.

kelemen commented 11 years ago

By the way, I meant "not possible" as "No such feature is currently implemented".

Forage commented 11 years ago

While I understand the reasons for not implementing the feature at this stage, I do think it will be a valuable addition for a future release. Determining the possible and proper values for a dependency (group, name, version) is a PITA to do manually.

Inserting from within the build script would indeed be a sensible option. Adding it outside of the build script, causing it just to add a plain "dependency" section or add it an existing one, would be useful as well, even if it means you'd have to do manual altering of the possible logic afterwards.

The dependency support does not have to be as extensive/complex as the Maven plug-in. I'm happy with one dialog, allow me to search by group or name, being presented with a list of versions and a dropdown to select the appropriate dependency configuration [1].

[1] http://www.gradle.org/docs/current/userguide/java_plugin.html#sec:java_plugin_and_dependency_management

kelemen commented 11 years ago

I do think it is useful as well, I just didn't want to fool anyone into thinking that I'm planning on working on this issue. Especially, if automatically inserting it into the buildscript should be done.

I think, appending a new "dependencies" block wouldn't be too good. Creating a pastable string seems better to me. Anyway, don't expect me working on this issue in the near future. My current priority is exploiting the new features introduced in Gradle 1.8. This needs quite a lot of refactoring and other work but will have a huge inpact.

However, if you (or anyone else) would implement such a dialog, I'll gladly take my time to integrate it into this plugin. Such a dialog can even be able to look for project dependencies.

I'll reopen this issue with a different title.

kelemen commented 11 years ago

I have just talked with Hans Dockter about this at JavaOne. He said that they were also asked by the Android team and this is something planned to be supported. So, after all this might get fixed. I can't say when though.

Forage commented 11 years ago

Great to hear and thank you for keeping us posted. I hope that the interest by the Android team will also generate some external contribution love to the NB Gradle and Android plugin in the future.