keleshev / schema

Schema validation just got Pythonic
MIT License
2.86k stars 214 forks source link

0.7.6 breaks import? #309

Closed ggainey closed 5 months ago

ggainey commented 5 months ago

Hey folks,

We just picked up 0.7.6, and it breaks us. Here's a test showing the problem:

~ $ mkvirtualenv schema-test
created virtual environment CPython3.12.2.final.0-64 in 583ms
  creator CPython3Posix(dest=/home/ggainey/.virtualenvs/schema-test, clear=False, no_vcs_ignore=False, global=False)
  seeder FromAppData(extra_search_dir=/usr/share/python-wheels,download=False, pip=bundle, via=copy, app_data_dir=/home/ggainey/.local/share/virtualenv)
    added seed packages: pip==23.2.1
  activators BashActivator,CShellActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator
virtualenvwrapper.user_scripts creating /home/ggainey/.virtualenvs/schema-test/bin/predeactivate
virtualenvwrapper.user_scripts creating /home/ggainey/.virtualenvs/schema-test/bin/postdeactivate
virtualenvwrapper.user_scripts creating /home/ggainey/.virtualenvs/schema-test/bin/preactivate
virtualenvwrapper.user_scripts creating /home/ggainey/.virtualenvs/schema-test/bin/postactivate
virtualenvwrapper.user_scripts creating /home/ggainey/.virtualenvs/schema-test/bin/get_env_details
(schema-test) ~ $ pip install schema
Collecting schema
  Obtaining dependency information for schema from https://files.pythonhosted.org/packages/82/bb/43b5df86e078c827f89478cbf38751fa2c945e73ecf1e490516832d46fef/schema-0.7.6-py2.py3-none-any.whl.metadata
  Downloading schema-0.7.6-py2.py3-none-any.whl.metadata (34 kB)
Collecting contextlib2>=0.5.5 (from schema)
  Obtaining dependency information for contextlib2>=0.5.5 from https://files.pythonhosted.org/packages/76/56/6d6872f79d14c0cb02f1646cbb4592eef935857c0951a105874b7b62a0c3/contextlib2-21.6.0-py2.py3-none-any.whl.metadata
  Using cached contextlib2-21.6.0-py2.py3-none-any.whl.metadata (4.1 kB)
Downloading schema-0.7.6-py2.py3-none-any.whl (10 kB)
Using cached contextlib2-21.6.0-py2.py3-none-any.whl (13 kB)
Installing collected packages: contextlib2, schema
Successfully installed contextlib2-21.6.0 schema-0.7.6

[notice] A new release of pip is available: 23.2.1 -> 24.0
[notice] To update, run: pip install --upgrade pip
(schema-test) ~ $ python3
Python 3.12.2 (main, Feb 21 2024, 00:00:00) [GCC 13.2.1 20231205 (Red Hat 13.2.1-6)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import schema as s
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'schema'
>>> 

And here is 0.7.5 not-breaking:

(schema-test) ~ $ pip install schema==0.7.5
Collecting schema==0.7.5
  Obtaining dependency information for schema==0.7.5 from https://files.pythonhosted.org/packages/0d/93/ca8aa5a772efd69043d0a745172d92bee027caa7565c7f774a2f44b91207/schema-0.7.5-py2.py3-none-any.whl.metadata
  Using cached schema-0.7.5-py2.py3-none-any.whl.metadata (34 kB)
Requirement already satisfied: contextlib2>=0.5.5 in ./.virtualenvs/schema-test/lib/python3.12/site-packages (from schema==0.7.5) (21.6.0)
Using cached schema-0.7.5-py2.py3-none-any.whl (17 kB)
Installing collected packages: schema
  Attempting uninstall: schema
    Found existing installation: schema 0.7.6
    Uninstalling schema-0.7.6:
      Successfully uninstalled schema-0.7.6
Successfully installed schema-0.7.5

[notice] A new release of pip is available: 23.2.1 -> 24.0
[notice] To update, run: pip install --upgrade pip
(schema-test) ~ $ python3
Python 3.12.2 (main, Feb 21 2024, 00:00:00) [GCC 13.2.1 20231205 (Red Hat 13.2.1-6)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import schema as s
>>> 

We're pinning to 0.7.5 for now.

skorokithakis commented 5 months ago

I've yanked this, thanks. I released because it was requested in #308, but it seems we aren't ready for that yet. If someone wants to test the release, I'd be happy to release 0.7.7.