search

keleshev / schema

Schema validation just got Pythonic
MIT License
2.86k stars 214 forks source link

fix: py.typed module ignored when building package #317

Closed maximeflya closed 2 months ago

maximeflya commented 3 months ago

fixes #316

Moved from a single module to a package in order for the py.typed file to be included

I tested building the package using python 3.8 and installed it. Mypy was able to read the package's types and it works without any code changes.

I manually checked that the py.typed file was stored in the wheel and in the tar.gz package

I ran pytest in python 3.8 and everything passed

skorokithakis commented 3 months ago

Looks good, thanks! Can you please also fix the precommit errors?

maximeflya commented 3 months ago

The workflow run did not contain the pyproject.toml file that defines the 120 character line length

skorokithakis commented 3 months ago

Since the linter changed a bunch of things, I'd like to run it myself to verify the changes. I'll hopefully get to it in the next few days, and then merge, thank you!

skorokithakis commented 2 months ago

Merged #319 instead.