Get deck lists - Githubissues

pak21 commented 4 years ago

While you can export your decks one at a time from Arena, that's tedious. Add parsing of all decks at once from the logfile.

This turned out to be only very slightly less trivial than it might have been:

The JSON parser could parse only top-level JSON objects, not top-level JSON arrays. Functionality added - although it will break if somebody calls their deck Silly Name ] (haven't actually tried to see if that's possible in the client).
I'm not 100% happy with how the "lookup cards" functionality means injecting MtgaLog into MtgaDeckList for just the card lookup functionality - in an ideal world, that functionality should probably live in a separate object. I think this is OK for now but happy to refactor a bit if you'd prefer.

kelesi commented 4 years ago

Sorry, I completely forgot about this PR. I have to check in the following week. It would be great if you could reslove the conflicts with my latest changes, though.

pak21 commented 4 years ago

Conflicts fixed, and test added for a "new format" array as well.

pak21 commented 4 years ago

Made a couple of updates here over the weekend, the important one was to fix for parsing deck lists from the new format log file. The exposing of the internal ID is because my use case needs a stable identifier for decks ;-)

kelesi / mtga-utils

Get deck lists #17