search

keller-mark / pizzarr

Slice into Zarr arrays in R 🍕
https://keller-mark.github.io/pizzarr/
MIT License
25 stars 2 forks source link

dog.ome.zarr is 6MB and .* files through lots of check notes. #87

Open dblodgett-usgs opened 4 weeks ago

dblodgett-usgs commented 4 weeks ago

Describe the bug The contents of .extdata don't play nice with R CMD check.

excerpt from check

❯ checking for hidden files and directories ... NOTE
  Found the following hidden files and directories:
    inst/extdata/bcsd.zarr/.zattrs
    inst/extdata/bcsd.zarr/.zgroup
    inst/extdata/bcsd.zarr/.zmetadata
    inst/extdata/bcsd.zarr/latitude/.zarray
    inst/extdata/bcsd.zarr/latitude/.zattrs
    inst/extdata/bcsd.zarr/longitude/.zarray
...

❯ checking installed package size ... NOTE
    installed size is  8.2Mb
    sub-directories of 1Mb or more:
      extdata   7.0Mb

To Reproduce Run > R CMD check

Expected behavior No notes.

I think we should replace the dog.ome with something smaller or subset it down to less than 1MB. We should also probably zip the contents of inst/extdata and unzip them as needed in examples. I wrote a demo data retriever here that does what I'm thinking.

https://github.com/DOI-USGS/rnz/blob/main/R/util.R#L12

dblodgett-usgs commented 5 days ago

Another option, if it's worth keeping the sizeable dog.ome sample is to use something like this https://github.com/DOI-USGS/nhdplusTools/blob/main/inst/extdata/utils.R which will pull data down from the repository for running examples.