search

kellerben / dudle

Online event coordination and survey application
https://dud-poll.inf.tu-dresden.de
GNU Affero General Public License v3.0
337 stars 67 forks source link

Accessibility: Textual alternatives for unicode symbols missing #129

Open KreerC opened 3 years ago

KreerC commented 3 years ago

The symbols used in the poll table do not have a suitable textual label for e.g. screen reader users. This could be done via aria-label or a an accessible popover containing a localized string like "yes", "no" and "maybe" as used in the code.

I'd appreciate a fix very much as this seems like a particularly easy thing to fix in poll.rb starting in line 285.

kellerben commented 3 years ago

you are right, this would be an easy fix. Wouldn't it be better to add this to the title in poll.rb line 290?

KreerC commented 2 years ago

I'm not familiar with the code per se, but I'd be happy to review a PR that implements a fix.

Also, for clarification, this should be considered a bug and receive a fix immediately because it renders the application unusable for a significant number of people.

kellerben commented 2 years ago

I added the aria-label to the input. In addition, I added the unicode symbol to the title. Can you please review it here: https://dudle.inf.tu-dresden.de/coffee/ the code is here: https://github.com/kellerben/dudle/blob/master/poll.rb#L290-L291

bkmgit commented 2 years ago

https://wave.webaim.org indicates the labels appear, though adding language used for the page would likely also be helpful for screen readers.