kellerkindt / ShowCaseStandalone

GNU General Public License v3.0
2 stars 9 forks source link

Prevent dropping air...its sort of pointless re shops. #9

Closed Narimm closed 6 years ago

Narimm commented 6 years ago

Basically a you will get an Illegal exception if you try and .dropItem (air)

Narimm commented 6 years ago

Yes this was with Paper...but I think it should be prevented on any Bukkit server

Caused by: java.lang.IllegalArgumentException: Cannot drop AIR.
        at org.apache.commons.lang.Validate.isTrue(Validate.java:136) ~[patched_1.12.2.jar:git-Paper-1387]
        at org.bukkit.craftbukkit.v1_12_R1.CraftWorld.dropItem(CraftWorld.java:337) ~[patched_1.12.2.jar:git-Paper-1387]
        at com.kellerkindt.scs.internals.SimpleShopHandler.onShowCaseItemSpawnEvent(SimpleShopHandler.java:757) ~[?:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor680.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:70) ~[patched_1.12.2.jar:git-Paper-1387]
        ... 20 more