search

kellerkindt / asn1rs

Generates Rust Code and optionally compatible Protobuf schema files from ASN.1 definitions.
http://asn1.rs
Apache License 2.0
54 stars 19 forks source link

Global and hierarchical state #69

Open masihyeganeh opened 3 years ago

masihyeganeh commented 3 years ago

I love this rustic implementation of parser using TryFrom but it needs a global state e.g. to support IMPLICIT/EXPLICIT/AUTOMATIC TAGS that will affect all sub structures

kellerkindt commented 3 years ago

Can you link and/or explain what the differences is between IMPLICIT/EXPLICIT/AUTOMATIC TAGS is? With uPER this didn't really matter until now

masihyeganeh commented 3 years ago

Yeah, as I said before, there is a good post in let's encrypt for that: https://letsencrypt.org/docs/a-warm-welcome-to-asn1-and-der/#explicit-vs-implicit

masihyeganeh commented 3 years ago

Hey @kellerkindt, Could you find spare time to look at this?

kellerkindt commented 3 years ago

TBH, I did not. I don't have a lot of time left over to work on this at the moment. But I want to at some point - maybe at or until Christmas I will have some spare time for this.

Regarding the state tracking and from what I have seen while glossing over the linked article, wouldn't it fit better in the Model type with an additional field?

kellerkindt commented 2 years ago

Cross referencing with #34 and #10