kellerza / pysma

Async library for SMA Solar's WebConnect interface
MIT License
59 stars 51 forks source link

Add definitions for the Secure Power Supply #103

Closed jordancarlson08 closed 2 years ago

jordancarlson08 commented 2 years ago

Hello! I would like to expose some additional data from the SMA web portal through pysma to home assistant. I have added the sensors to definitions.py. I have done my best to follow existing patterns and documentation. I'm also not sure if I'm missing anything else to be able to access this data in home assistant. Any guidance would be greatly appreciated.

Thanks in advance!

kellerza commented 2 years ago

Thanks @jordancarlson08 ! It will be included once when we release a new pysma

codecov[bot] commented 2 years ago

Codecov Report

Merging #103 (96cc243) into master (415d09d) will decrease coverage by 36.06%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##            master     #103       +/-   ##
============================================
- Coverage   100.00%   63.93%   -36.07%     
============================================
  Files            6        6               
  Lines          424      427        +3     
============================================
- Hits           424      273      -151     
- Misses           0      154      +154     
Impacted Files Coverage Δ
pysma/definitions.py 100.00% <100.00%> (ø)
pysma/__init__.py 19.04% <0.00%> (-80.96%) :arrow_down:
pysma/sensor.py 98.88% <0.00%> (-1.12%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rklomp commented 2 years ago

@kellerza Could you check why code coverage went down with this change?