kellerza / pysma

Async library for SMA Solar's WebConnect interface
MIT License
59 stars 51 forks source link

Fix pre-commit hook #118

Closed frimtec closed 1 year ago

frimtec commented 1 year ago

I was not able to use pre-commit hook in this project:

      RuntimeError: The Poetry configuration is invalid:
        - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

After some googling I found the following article that explains the issue in details: https://levelup.gitconnected.com/fix-runtimeerror-poetry-isort-5db7c67b60ff

The fix is quite simple, updating the isort dependency to 5.12.0.

With that change the pre-commit hook works as expected.

codecov[bot] commented 1 year ago

Codecov Report

Merging #118 (ccab4fd) into master (fcdcd0c) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #118   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          432       432           
=========================================
  Hits           432       432           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.