Closed rklomp closed 3 years ago
Merging #68 (41fb89b) into master (9953118) will increase coverage by
2.22%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 93.47% 95.69% +2.22%
==========================================
Files 5 6 +1
Lines 383 395 +12
==========================================
+ Hits 358 378 +20
+ Misses 25 17 -8
Impacted Files | Coverage Δ | |
---|---|---|
pysma/__init__.py | 90.47% <100.00%> (+5.38%) |
:arrow_up: |
pysma/const.py | 100.00% <100.00%> (ø) |
|
pysma/exceptions.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9953118...41fb89b. Read the comment docs.
Add exceptions. All methods should return a valid value. If not, an exception should be raise. These exceptions can be handled in HA to more easily provide feedback when things go wrong during setup or polling of data.
ConfigEntryNotReady
if unable to connect during entry setupMakes it easier to create a reauth flow in the future
Also
_fetch_json
has been renamed to_post_json
and new method_get_json
was added. These both call_request_json
.ClientTimeout
instead ofasync_timeout
(dependency removed)for _ in range(3)
have been removed. It just fails and theDataCoordinator
in HA will handle the retries.