search

kellerza / pysma

Async library for SMA Solar's WebConnect interface
MIT License
59 stars 51 forks source link

fix unit for temperature sensors #84

Closed popoviciri closed 2 years ago

popoviciri commented 2 years ago

To be correctly identified as temperature sensors, the unit for battery and optimizer temperatures must be "°C" instead of "C". Otherwise they're empty device_class sensors.

codecov[bot] commented 2 years ago

Codecov Report

Merging #84 (ca837e8) into master (8c9f7b7) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #84   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          416       416           
=========================================
  Hits           416       416
Impacted Files Coverage Δ
pysma/definitions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c9f7b7...ca837e8. Read the comment docs.

rklomp commented 2 years ago

Thanks @popoviciri I will release a new version. Can you update the dependencies op HA and create a pull request there as well?

popoviciri commented 2 years ago

Hi @rklomp, will do. Thank you!