kellerza / sunsynk

Deye/Sunsynk Inverter Python library and Home Assistant OS Addon
https://kellerza.github.io/sunsynk/
MIT License
204 stars 87 forks source link

Not really an issue, but a feature request #153

Closed zs3y closed 1 year ago

zs3y commented 1 year ago

Issue related to

Sunsynk / mbusd Home Assistant Add-On

Describe the issue/bug

NOT a bug, but a feature request.

Since the Sunsynks built in clock is a bit on the drifty end, would it be possible to enable a once a week or once a day time syncronisation to the machine running the add-on. I am pretty certain that just about every HA instance on bare metal is, with ntp, pretty much correct, time wise. Even HA in a VM is likely to run on a host that is ntp time syncronised and has more accurate time than the inverter. Maybe a on/off toggle to enable/disable this feature if there's someone out there that does not want it.

Expected behavior

Assume the toggle to enable this feature, then at, let's say 00:00:00 on a daily basis the add-on should update the date and time of the inverter to the correct/current date and time. Most likely once a week on a Monday or Sunday morning would probably also be plenty.

Your environment

Logs

No log to add

Additionally

I must admit, I looked at the example, but cannot figure this lot out, otherwise I would have done this myself, I must thank you, though, even if this feature request gets ignored or deemed not worthwhile, this integration for the Sunsynk is working pretty great and allows me to put automations in place that weren't possibly without it, always trekking to the garage to make changes was getting a bit old.... :-)

kellerza commented 1 year ago

Hi @zs3y - this should work if you write to the date_time sensor. It might be a bit slow to read (see #112), but writing should be immediate - the format is 2023-06-19 00:00:00 see here

kellerza commented 1 year ago

If you have a working automation (with the correct template to write to the sensor), it might be something worth adding to the addon docs?

zs3y commented 1 year ago

HELP! Not a working automation but...in the log... 2023-07-26 14:11:28,186 CRITICAL Writing sensor date_time=2023-07-26 14:11:20 [(22, 23, 24)=(5895, 6670, 2836)]

If I try and set the time, the above (with the time and date changed to suit the actual event date and time) appears in the Sunsynk log... no actual date or time is written to the inverter, is there something I'm overlooking? I am just using the entry on lovelace and am changing the time component to suit and hitting enter at the appropriate moment. Screen Shot 2023-07-26 at 2 23 11 PM and in the logbook the entries are for this instance... Screen Shot 2023-07-26 at 2 26 34 PM

which means to me, it wants to update the date and time to the specified values, but this actually does no happen...

Hoe nou? wat maak ek verkeerd? Help!