FR: Expand scope to include sunsunk OEM'd inverters like Sol-Ark

kellerza / sunsynk

Deye/Sunsynk Inverter Python library and Home Assistant OS Addon

https://kellerza.github.io/sunsynk/

MIT License

193 stars 83 forks source link

FR: Expand scope to include sunsunk OEM'd inverters like Sol-Ark #27

Closed poldim closed 1 year ago

poldim commented 2 years ago

I've got a Sol Ark 12k which is a Sunsynk in wool's clothing. I did read that some of the registers are different. Here is the list I have what works on my config and matches that from the other HA addon.

kellerza commented 2 years ago

How many of these are actually different?

The list you shared includes all registers, so not really sure what the expectation/delta is here

poldim commented 2 years ago

I did a quick check and surprisingly most of them are a match. It looks like you have 16 points that are called power but the units are energy so those should be updated

kellerza commented 2 years ago

Thanks, yes, the addon started life from a translated Chinese modbus spec, so they all started their life as mostly time x power, so day/month/year/total and power/import/export/charge/discharge. Although it might not be 100% correct, I also did not want to change all the energy sensors (it effects everyone's HA energy stats). I did fix/deprecate some confusing power ones a while back.

166 is the aux port, where you would connect a generator - maybe they are the same?

I've never had the need for 200-202, and they seem duplicates of 84-86. Since you only need to feed totals into HA energy management, not sure how useful they are

If we prepend these 4 with "Solark " we could probably add definitions? Or any other suggestions?

poldim commented 2 years ago

I know breaking changes suck but the option to have incorrect names seems like a worse one. Obviously it's your call.

The Chinese translation/label is "Gen makes the power of micro-reverse input / Gen Do Micro Inverse Power Input". I just checked mine and it's still at zero but I'm currently not connected to my gen/smartload breaker.

200+ appear to be configuration of the battery system charging which are different from energy used in 84-86

A prefix on the entity name is fine, you can also disable them by default if you think they will be rarely used.

kellerza commented 1 year ago

Implemented your suggestion in version 0.2.0 of the library. Should makes its way into the dev version of the addon first