Merge few definitions from HV to common and from common to LV

kellerza / sunsynk

Deye/Sunsynk Inverter Python library and Home Assistant OS Addon

https://kellerza.github.io/sunsynk/

MIT License

209 stars 88 forks source link

Closed rixxxx closed 5 months ago

rixxxx commented 5 months ago

Move unnumbered battery sensors to LV definition, currently they get picked up by eg power_flow_card package and produce additonal sensors with wrong values.
Replace common Grid Connected with the one from HV definition. Sensor 194 is probably inherited from 1PH definition and doesn't work.
Deprecate LV Grid Conneced Status and move HV version of it to common.
Remove HV Rated power and ProgX power definitions. They are the same what is already in common.

Tested on HV. Partly tested on LV.

rixxxx commented 5 months ago

Positive test results on 3PH LV too.

kellerza commented 5 months ago

Thanks, can you remove the test_migration test cases?

It does not make sense to try keep these around&fix them

rixxxx commented 5 months ago

Sure

kellerza commented 5 months ago

LGTM 🐬

Thanks @rixxxx !