Directory names are quoted inconsistently

kelleyma49 / PSFzf

A PowerShell wrapper around the fuzzy finder fzf

MIT License

787 stars 34 forks source link

Directory names are quoted inconsistently #116

Closed pitkali closed 2 years ago

pitkali commented 2 years ago

Get-FileSystemCmd takes a path argument but only quotes it for fd. In particular, note the following:

On Windows, default filesystem commands have the directory argument in quotes already.
On Linux, the argument is not in quotes.
Default FD commands do not have argument in quotes, but quote it in Get-FileSystemCmd if it has space.

As a result, Invoke-Fzf on Linux doesn't work if invoked directly inside a directory with spaces in the name.

pitkali commented 2 years ago

I have fixed this in c23e83e258d1c94b51996845154b78300444a9c2 but it overlaps #115 so either I wait with pull request until that is solved or rebase it and then #115 will require change.