search

kelleyma49 / PSFzf

A PowerShell wrapper around the fuzzy finder fzf
MIT License
755 stars 35 forks source link

Chord does not work on VIMode Command #133

Closed belotn closed 1 year ago

belotn commented 2 years ago

All defined chord with Set-PSFzfOption do not work when in vimode "Command". Maybe that's by design ?

kelleyma49 commented 2 years ago

Can you list recreation steps?

bedware commented 1 year ago

I stumbled upon that issue too. I created a small PR to fix that.

If you are not aware of how you can test that you can do these few steps:

bedware commented 1 year ago

@belotn hello 👋 Could you review the changes, please?

kelleyma49 commented 1 year ago

@bedware , not sure if you saw that @belotn 's PR is merged? Are you still having issues?

bedware commented 1 year ago

@kelleyma49, you confused me and @belotn. I created the PR and ofc I tested my changes. It works. I just want to close the issue and asked the topic starter to test it and give feedback to get enough arguments to close the issue.

kelleyma49 commented 1 year ago

My apologies for the confusion!

Can we close this out?

bedware commented 1 year ago

It looks like @belotn is not eager to check the fix. I think you can close it. At least I've checked it. After all, the goal is to make them less, not more.

belotn commented 1 year ago

Sorry for the delay. I close the case.