search

kelleyma49 / PSFzf

A PowerShell wrapper around the fuzzy finder fzf
MIT License
748 stars 35 forks source link

Can potentially break oh-my-posh and starship #189

Open brian6932 opened 1 year ago

brian6932 commented 1 year ago

Original thread: https://github.com/JanDeDobbeleer/oh-my-posh/issues/2758 I am not aware of who/what the responsible party is in this, however, since the dev of oh-my-posh wasn't sure who/what was responsible either, I opened this mirror issue

mattcargile commented 1 year ago

I've had this happen before seemingly randomly. It may be related to when I zoom in and out in Windows Terminal. I usually have to clear/cls the screen or use CTRL + l to "clear" the screen. I think we'll need a better repro to really get to the bottom of it.

sim590 commented 11 months ago

Also see my bug report on oh-my-posh:

https://github.com/JanDeDobbeleer/oh-my-posh/issues/4122

It seems like it is the same. It's easy to reproduce the way I do it, I feel.

riotrah commented 4 months ago

Just bumping this - this is quite a weird bug. sim590's bug report is more thorough and reaffirms that this is likely due to PSFzf's implementation and not something about oh-my-posh specifically.

kelleyma49 commented 4 months ago

I can't recreate this issue. See the attached video. Do you have a language set other than English?

My environment:

PowerShell 7.4 fzf 0.46.1 Oh My Posh 19.11.3 CaskaydiaCove Nerd Font

oh-my-posh

brian6932 commented 2 months ago

No, I use Shell: PowerShell 7.5.0-preview.2 Terminal: alacritty 0.14.0-dev oh-my-posh: 19.24.2 fzf: 0.50.0 (f97d275) PSFzf: c604e1b7e4b91fda98815aeee45c036da5fcb8cb Theme: Pure

I ever so slightly modify the Pure theme (I disable the transient_prompt). Repeatedly pressing CTRL+R or TAB can often repro this bug (and make sure you have long shell history, larger than your window size).

sim590 commented 2 months ago

@kelleyma49 In your video you seem to mostly be using ENTER or any other key input that would end up selecting the line your cursor was on. However, my report stated that I interrupt the program in order to get the issue, so you would need to interrupt FZF with CTRL+c. Do it repeatedly and you should trigger the issue quickly...

brian6932 commented 2 months ago

Yes, I typically used ESC