Add powershell to the officially supported shells in fzf

kelleyma49 / PSFzf

A PowerShell wrapper around the fuzzy finder fzf

MIT License

819 stars 37 forks source link

Add powershell to the officially supported shells in fzf #4

Open vors opened 7 years ago

vors commented 7 years ago

This is a follow-up from my comment https://github.com/kelleyma49/PSFzf/issues/1#issuecomment-263048321

I think it would be awesome to add PS support to the official fzf repo.

As far as I see it requires just implementing Ctrl-R, Alt-C, Ctrl-T as a standalone key-binding.ps1 file that install script will add dot-source from the $profile

kelleyma49 commented 7 years ago

That would be consistent with fzf on the other platforms. To get this done we should probably create a pull request for the fzf repo. I'll look into it when I have some more free time.

stinos commented 7 years ago

a standalone key-binding.ps1 file that install script will add dot-source from the $profile

Wouldn't that create a bit of a mismatch between this method and the standard Install-Module PSFzf way? Or isn't that an issue.

Anyway I also thing PSFzf should be the way to use fzf on PS. I have a feeling there's a ton of people out there who don't know what they are missing :]. Would maybe be worth it creating a PR to get PSFzf mentioned in the fzf readme?