search

kellnerd / musicbrainz-scripts

Bookmarklets and Userscripts for MusicBrainz.org
MIT License
31 stars 2 forks source link

Relationship editor scripts no longer work with VM 2.13.5 #33

Closed HibiscusKazeneko closed 1 year ago

HibiscusKazeneko commented 1 year ago

If I click on "Edit relationships" on a release, the parser will not appear. This only started today.

I'm running the script through Violentmonkey 2.13.5 on Firefox 108.0.2 on macOS Ventura 13.1.

kellnerd commented 1 year ago

Yeah, I can confirm that error for both my relationship editor scripts (VM 2.13.5, FF 108.0.1). I'm seeing lots of new errors of the same type in the browser console, a whole lot of other userscripts (which require access to page variables like $ or MB) has also stopped working, so it's probably a general problem with the new VM version:

ReferenceError: MB is not defined

Might be https://github.com/violentmonkey/violentmonkey/issues/1708, I'll investigate whether that's the issue and we just have to wait for an update or whether I can do something to fix all these scripts.

Edit: Or I should finally look into Sharing objects with page scripts. IIRC the same issue also stopped some userscripts from working with Greasemonkey 4.x, so maybe I could solve two problems this way.

kellnerd commented 1 year ago

Indeed, Violentmonkey BETA v2.13.5.2 fixes the issues with all of these scripts for me. You could install that beta version or wait for the next release which will probably come soon (according to the issue linked above).

P.S. While we are talking about beta versions: If you're using beta.musicbrainz.org occasionally, you could also install the beta version of the copyright parser userscript which also supports the beta relationship editor. The only reason I haven't published it yet, is because my other relationship editor script is not fully working on beta so far (see #32).

kellnerd commented 1 year ago

This should no longer happen with Violentmonkey 2.13.7