Multi-paragraph messages with CRLF ignore later paragraphs - Githubissues

kellpossible / cargo-i18n

A Rust Cargo sub-command and libraries to extract and build localization resources to embed in your application/library

MIT License

121 stars 25 forks source link

Multi-paragraph messages with CRLF ignore later paragraphs #57

Closed str4d closed 3 years ago

str4d commented 3 years ago

This occurs on both i18n-embed 0.9.4 and the current release (0.10.1). I believe this was caused by #36 being closed.

Minimal reproduction:

https://github.com/str4d/rage/commit/8c67875fafb1fa9eaa072f53ddb342ed09e6faa1 upgrades i18n-embed from 0.9.3 to 0.9.4.
Before that commit, all tests pass, including Windows: https://github.com/str4d/rage/runs/1678885056
After that commit, Windows fails due to fl! not finding translation arguments, but all other tests pass: https://github.com/str4d/rage/runs/1685569886
The specific fluent messages are here: https://github.com/str4d/rage/blob/8c67875fafb1fa9eaa072f53ddb342ed09e6faa1/age/i18n/en-US/age.ftl#L66-L96

kellpossible commented 3 years ago

Thanks @str4d I'll look into this today

kellpossible commented 3 years ago

This seems likely to be an upstream issue with fluent, I'll try to make a minimal example to be sure, maybe it's a problem in i18n-embed. I had assumed this be fixed with fluent 0.13 but seems to be still broken for this case, I'll report it there, and re-insert the work-around if that's the case.

kellpossible commented 3 years ago

I have reported this as an upstream issue https://github.com/projectfluent/fluent-rs/issues/213

As a quick workaround you can put indentation between the breaks, ensure that your editor doesn't delete them. I'll re-insert the previous workaround and push a new release soon.

kellpossible commented 3 years ago

Workaround now published in i18n-embed version 0.10.2. Does this solve the problem for you @str4d ?

str4d commented 3 years ago

Yes, the workaround fixes my Windows tests. Thanks!

kellpossible commented 3 years ago

Awesome! I guess I'll close this one then :slightly_smiling_face: