search

kellyclaus / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Concise CSS #4

Open aubreywullschleger opened 6 years ago

aubreywullschleger commented 6 years ago

Great! Nice use of the html selector in your CSS. The use of the html selector helps keep your CSS concise especially when using inherited styles on the selector as you've done with font-family:Helvetica, sans-serif; here.

https://github.com/kellyclaus/prj-rev-bwfs-dasmoto/blob/master/DasmotoArtsCrafts/Resources/style.css#L1-L4

Here, I would consider using group selectors for any other repeated styles like font-weight: bold; to make your CSS even more concise.

kellyclaus commented 6 years ago

Oh okay, so I might do this instead?

h1.pagetitle, .price, h2 { font-weight:bold; }

h1.pagetitle { color:khaki; font-size:100px; text-align:center; }

.price { color:blue; }

h2 { color: white; font-size: 32px; }