kellyethridge / VBCorLib

The VBCorLib framework brings many of the powerful .NET classes to VB6.
http://www.kellyethridge.com/vbcorlib/
MIT License
115 stars 28 forks source link

BinaryWriter missing LeaveOpen construction parameter. #28

Closed kellyethridge closed 3 years ago

kellyethridge commented 4 years ago

The BinaryWriter has no support for leaving the base stream open when the writer is disposed of. The writer will close the underlying stream regardless of intent.

The BinaryWriter should support the LeaveOpen option allowing for the writer to either flush the underlying stream when the option is true or close the underlying stream when the option is false.

This would be a breaking change. May be able to use project compatibility.

kellyethridge commented 3 years ago

Fixed in v4.0.