kellyethridge / VBCorLib

The VBCorLib framework brings many of the powerful .NET classes to VB6.
http://www.kellyethridge.com/vbcorlib/
MIT License
112 stars 28 forks source link

CorString comparison methods should default to StringComparison.CurrentCulture. #79

Closed kellyethridge closed 3 years ago

kellyethridge commented 3 years ago

Methods in CorString that compare strings in some fashion should do a StringComparison.CurrentCulture by default to align with .NET. Currently they are defaulting to StringComparison.Ordinal.

I should have known since in .NET there is a String.CompareOrdinal method defined. Why have that method and the String.Compare method default to StringComparison.Ordinal which would just be duplicate behavior.

This would be a breaking change in compile and runtime.