search

kellymclaughlin / rebar3-eqc-plugin

A rebar3 plugin to enable the execution of Erlang QuickCheck properties
Apache License 2.0
13 stars 20 forks source link

Add --sname and --name options to allow testing with distributed nodes #17

Closed ThomasArts closed 8 years ago

ThomasArts commented 8 years ago

This solves the problem of being able to start slave nodes from within QuickCheck specifications and therewith allows for testing with different nodes. I assume the slave nodes to be started from the master node and therefore did not care about also adding a flag to set the cookie on the node.

ferd commented 8 years ago

Rather than using rebar_utils:abort, I recommend using rebar_api:abort (http://www.rebar3.org/docs/plugins#section-rebar-api) since we commit to keeping this backwards compatible for plugins.

Also it appears to me that you're using the code from rebar_prv_shell that I had developed there for that. It might be worth it for me to move that code out of that module and plug it in rebar_api so that it's easier to use for multiple plugins such as this one. How'd you feel about that?

ThomasArts commented 8 years ago

I did indeed have a look at rebar_prv_shell and made it less depending on header files and such.

I am indifferent to the function names, thus yes, use the one that suite rebar best. It is an excellent idea to make the part of rebar_prv_shell that can be used more general available via an api, that would mean less maintenance for any plugin that wants to use distributed nodes.

Would you like me to do anything now, or do you just fix it? Regards Thomas

On 25 Feb 2016, at 17:40, Fred Hebert notifications@github.com wrote:

Rather than using rebar_utils:abort, I recommend using rebar_api:abort (http://www.rebar3.org/docs/plugins#section-rebar-api http://www.rebar3.org/docs/plugins#section-rebar-api) since we commit to keeping this backwards compatible for plugins.

Also it appears to me that you're using the code from rebar_prv_shell that I had developed there for that. It might be worth it for me to move that code out of that module and plug it in rebar_api so that it's easier to use for multiple plugins such as this one. How'd you feel about that?

— Reply to this email directly or view it on GitHub https://github.com/kellymclaughlin/rebar3-eqc-plugin/pull/17#issuecomment-188870029.

kellymclaughlin commented 8 years ago

I'm happy to merge the PR as-is and then the updates can be pulled in to use the additions to rebar_api as they become available.