search

kellyselden / broccoli-jscs

Broccoli plugin for jscs
MIT License
16 stars 16 forks source link

Upgrade Minimum JSCS Version #45

Closed CrshOverride closed 9 years ago

CrshOverride commented 9 years ago

JSCS 2.3.2 fixes a few critical bugs for those using ES6 syntax (disallowParenthesesAroundArrowParam was the stopper for my current project).

After upgrading the minimum version, all unit tests still pass and I haven't seen any issues when running against our large-ish Ember CLI application.

kellyselden commented 9 years ago

all versions starting with a 2 are covered by the semver carat ^ hint.

CrshOverride commented 9 years ago

With the updated hint, wouldn't 2.3.2 be used as the minimum allowed version though which would force the upgrade from buggier versions of jscs? I'm still not 100% clear on when Node allows/installs different versions of packages based on the hints.

kellyselden commented 9 years ago

This lib functions as a pass-through to the most recent version of jscs. I think its acceptable that if someone who already has broccoli-jscs installed wants a bugfix release of jscs, to just reinstall broccoli-jscs. Otherwise, we would be releasing new versions for every point release of jscs, which is overkill in my opinion.

CrshOverride commented 9 years ago

:+1: Thanks for clarifying!