Closed adam-knights closed 8 years ago
@kellyselden Any more info you would like me to provide?
@adam-knights Are you using broccoli-jscs directly or ember-suave? If directly, can you try installing master and see how that works?
Directly, i'll try master now. (Incidentally, is directly still recommended?)
ember-suave can give you ember specific custom rules, but if you are using the default rules, than directly is perfectly fine.
@kellyselden It's slightly inconsistent to reproduce, but I'm 98% sure master does infact fix it. Are you cutting a release soon?
@adam-knights yep, when I get some time, probably tonight.
Cool, i'll close this now then and if we are in the other 2% i'll reopen.
Today I added the rule
"requireEnhancedObjectLiterals": true
.Steps to reproduce:
1) Restart Ember CLI
2) load localhost:4200/tests
3) Browse to a file with multiple failures of this rule, eg:
4) Look at the failing test - we see 10+ reasons that this rule is broken.
5) Change one of the occurences, say
willDestroy: function()
to `willDestroy().6) Test reloads - it passes, even though there should be further issues.
Here is my .jscsrc file:
Brocolli jscs v1.2.2, underneath latest jscs 2.9.0.
More info:
7) Restart Ember CLI - test still shows as passing when it should not.
8) Stop CLI, run rmdir /s /q node_modules bower_components dist tmp (windows), npm install, bower install, start cli, test shows up as failing correctly.
So something to do with files made on disk?
Edit 2
Saw this today in a test on a different rule - "maximumLineLength": 160. The test passed even though I was past 160, having fixed a different occurence of it.
This has only started happening in the last couple days, in which I also cleared out my node and bower folders - so could be related to a new release of something brocolli-jscs depends on. So if testing this please pull latest version of all dependencies. But it hand't been long before that when I last cleared them, so specifically a release of a dependency fairly recently?