Project Feedback - Githubissues

kellyskarritt commented 7 years ago

@chrisvfritz Can you take a look at this? It's hosted here and meets the following criteria:

[x] Your project is built off this base HTML and CSS (you may modify both pages however you want, e.g. adding classes or more elements)
[x] The website looks (nearly) identical to this mockup -- colors must be exact, spacing/sizes should be within about 5px (use the Page Ruler extension to measure exact sizes/spacing; you might need to open the image in a new tab)
[x] Any CSS selectors or properties may be used, though the project is possible using only what you saw in the lesson
[x] No spacing HTML (e.g. <br>, &nbsp;) is added to index.html
[x] Add at least one link (a element) to the page and style them to be purple normally, but turn orange on hover

chrisvfritz commented 7 years ago

Wow, that was quick! 😄 I haven't looked at the CSS yet, but I do see one area where I think we can get a little closer to the mockup: in the spacing between images. Below, you'll see that your version (on the left) has quite a bit more space between images than the mockup (on the right):

Mockup difference

kellyskarritt commented 7 years ago

Fixed it! thanks

chrisvfritz commented 7 years ago

Beautiful! 🎉 👍 :shipit:

kellyskarritt / MI-449-SS17-740-css-intro-iMnt09

Project Feedback #1