Project Feedback

[kellyskarritt]

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

• [x] At every URL, you respond with HTML, starting with an h1 element (though for this project, it doesn't have to be a complete HTML page)
• [x] When a user visits /, they see a greeting
• [x] When a user visits /random-joke, they see one of at least three knock-knock jokes (Math.random() may be useful 😉)
• [x] When a user visits /cuteness, they see a picture of a cute animal (I'm sure you can find one on the Internet 😛)
• [x] At every other URL, display an error page (if you want to make it funny, see these examples for inspiration)
• [x] The error page includes the requested URL, similar to Google's error page
• [x] Every page that is not the homepage (/) contains a link to it

[egillespie]

Hi @kellyskarritt, this is a fantastic start! It looks like you really captured the idea of manual routing (a.k.a. the giant if/else block of doom).

There are a couple of quirks with the content you're generating, though:

Remove http://localhost:8080 from links

It looks like all of your links are pointing at http://localhost:8080. If you remove this, then your links will work no matter where you deploy your hosted site.

Generate a random joke for each request

Right now you're generating a random number one time at the top of your code. If I refresh the page, I will never get a new random joke.

That's because only the code between lines 4 and 51 run each time I go to a page on your site. All of the other code runs once when the server starts.

If you move your random number generator inside your createServer function, it should show a new random joke when I refresh the page.

---

After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! :rocket:

[kellyskarritt]

All done! Thanks

[egillespie]

Nailed it! 🔨 :shipit: